[WIP] Schema v2#2469
Closed
lmolkova wants to merge 2 commits intoopen-telemetry:mainfrom
Closed
Conversation
|
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Early prototype of the new schema URL story. Built on top of #2307
Try it out with
make generate-schema-v2-dev NEXT_SEMCONV_VERSION=1.36.0What it generates:
Not done yet:
Problems found so far:
diff data has no stability properties, not possible to generate stable one
I'm not sure if lineage is really important on the resolved schema, do we actually need it checked in?
Can be pretty big
```yaml lineage: provenance: registry_id: main path: /home/weaver/source/cli/spans.yaml attributes: error.type: source_group: registry.error inherited_fields: - brief - examples - note - stability locally_overridden_fields: - requirement_level process.command_args: source_group: registry.process inherited_fields: - brief - examples - note - stability locally_overridden_fields: - requirement_level process.executable.name: source_group: registry.process inherited_fields: - brief - examples - note - stability locally_overridden_fields: - requirement_level process.executable.path: source_group: registry.process inherited_fields: - brief - examples - note - stability locally_overridden_fields: - requirement_level process.exit.code: source_group: registry.process inherited_fields: - brief - examples - note - stability locally_overridden_fields: - requirement_level process.pid: source_group: registry.process inherited_fields: - brief - examples - note - stability locally_overridden_fields: - requirement_level ```