Conversation
…ferent directories.
…attribute registry focused.
docs/registry/entities/aws-log.md
Outdated
|
|
||
|
|
||
|
|
||
| # Aws Log |
docs/registry/entities/aws-ecs.md
Outdated
|
|
||
|
|
||
|
|
||
| # Aws Ecs |
There was a problem hiding this comment.
leaving comment here, but it's a general question:
what would we do for metrics/events/spans in the future - would we group them by the root namespace or render each in a separate file?
I think it makes sense to group them (e.g. all HTTP metrics in one doc) - having one per file feels too granular. But that's what we generate here and it matches current resource docs layout
There was a problem hiding this comment.
Yeah - I think having one per file DOES make a lot of sense. I can update the entity registry to do that too.
| <thead> | ||
| <tr> | ||
| <th>Namespace</th> | ||
| <th>Entity</th> |
There was a problem hiding this comment.
maybe
| <th>Entity</th> | |
| <th>Entities</th> |
?
The rendering is a bit weird
so it took me a bit to understand there could be more than one, so maybe plural would be a bit more clear?
There was a problem hiding this comment.
Yeah - I'm still toying with making this look good. This is a prototype that SHOULD be just enough wrong it give speople a good idea of what it should be :).
Agree it could be called Entities, but if you have other ideas for how to organize the information, I'm all ears.
trask
left a comment
There was a problem hiding this comment.
what do you think about renaming
/docs/attributes-registry --> /docs/registry/attribute/
in a separate PR first, to make it easier to review the mass mechanical changes separately?
Of course. This is a "demo" of what we could do, hence it's still draft. I'd like to align on what we think "looks right" and then do all the updates. The Website changes in this PR are also somewhat dubious, but hard to showcase without importing this PR into the opentelemetry.io project to show it off... |
Opened a PR for this now. |
Reworks our registry generation so we have a registry we can provide links to for both attributes and entities.
Merge requirement checklist
[chore]