[db] rename db.system to db.system.name for metrics and update values#1917
Merged
trask merged 4 commits intoopen-telemetry:mainfrom Feb 18, 2025
Merged
[db] rename db.system to db.system.name for metrics and update values#1917trask merged 4 commits intoopen-telemetry:mainfrom
db.system to db.system.name for metrics and update values#1917trask merged 4 commits intoopen-telemetry:mainfrom
Conversation
3 tasks
arminru
approved these changes
Feb 18, 2025
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
db.system to db.system.name for metricsdb.system to db.system.name for metrics and update values
trask
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1581 , relevant to #1734
Changes
Rename
db.systemtodb.system.namefor metrics, and update the values to be consistent with database spans.Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]