rpc: add aws_api to well known rpc.system values#1622
Closed
Flarna wants to merge 9 commits intoopen-telemetry:mainfrom
Closed
rpc: add aws_api to well known rpc.system values#1622Flarna wants to merge 9 commits intoopen-telemetry:mainfrom
Flarna wants to merge 9 commits intoopen-telemetry:mainfrom
Conversation
dbbb942 to
811b5ca
Compare
AWS SDK uses RPC conventions therefore add the value used for rpc.system. Adapt the name for aws-api to aws_api to match existing conventions.
811b5ca to
5e516a6
Compare
dyladan
approved these changes
Nov 27, 2024
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
3 tasks
lmolkova
requested changes
Dec 14, 2024
Member
lmolkova
left a comment
There was a problem hiding this comment.
we've had this discussion on some other PR, I don't think aws_api fits into RPC system. Looking at its usage, it's not a remote procedure calling protocol, but a logical operation kind that describes AWS SDK API call.
We don't use rpc.system to describe database or other logical operations.
I suggest to
- try to understand the scenarios where it's important to know that span is describing AWS SDK call
- if it's really necessary, suggest a different attribute that can capture this information. Ideally it should not be specific to AWS SDK and can cover some generic cases
3 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1545
Changes
AWS SDK uses RPC conventions therefore add the value used for
rpc.system.Adapt the name for
aws-apitoaws_apito match existing conventions.Merge requirement checklist
[chore]