Rename feature_flag.system back to feature_flag.provider_name#1614
Merged
lmolkova merged 4 commits intoopen-telemetry:mainfrom Nov 27, 2024
Merged
Rename feature_flag.system back to feature_flag.provider_name#1614lmolkova merged 4 commits intoopen-telemetry:mainfrom
feature_flag.system back to feature_flag.provider_name#1614lmolkova merged 4 commits intoopen-telemetry:mainfrom
Conversation
3 tasks
Member
|
Should I assume this is a temporary reversion until a final decision is made regarding #1581 et alia? |
Member
Author
yes, this is temporary until we have a final consistent pattern. |
dyladan
approved these changes
Nov 27, 2024
AlexanderWert
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #1613
Given uncertainty around
*.systemattribute, I'd like to revert recent unreleased changes tofeature_flag.systemand rename it back tofeature_flag.provider_name. This would reduce number of breaking changes.We can't call it
feature_flag.provider.nameyet due to const name collision with existing ``feature_flag.provider_name` - #1462Merge requirement checklist
[chore]