Update enduser domain and add enduser.pseudo.id#1456
Merged
lmolkova merged 56 commits intoopen-telemetry:mainfrom Feb 3, 2025
Merged
Update enduser domain and add enduser.pseudo.id#1456lmolkova merged 56 commits intoopen-telemetry:mainfrom
enduser.pseudo.id#1456lmolkova merged 56 commits intoopen-telemetry:mainfrom
Conversation
0a8b0e8 to
ee0970f
Compare
heyams
commented
Oct 7, 2024
lmolkova
reviewed
Oct 14, 2024
enduser.authentication.id
…s/semantic-conventions into heya/add-enduser-namespace
Contributor
Author
|
need some advice with this weaver error, it didn't point to any files that I have modified. it's persisting. |
Member
if you scroll up from there, you'll see:
which looks related to this file that was deleted in your PR: |
joaopgrassi
previously requested changes
Oct 29, 2024
lmolkova
reviewed
Jan 28, 2025
trask
reviewed
Jan 29, 2025
…s/semantic-conventions into heya/add-enduser-namespace
lmolkova
reviewed
Jan 31, 2025
lmolkova
approved these changes
Jan 31, 2025
trask
reviewed
Jan 31, 2025
trask
reviewed
Jan 31, 2025
trask
approved these changes
Jan 31, 2025
MSNev
approved these changes
Jan 31, 2025
jsuereth
approved these changes
Feb 3, 2025
Contributor
jsuereth
left a comment
There was a problem hiding this comment.
Thanks for updating this! I realize it took a long time to get to it.
I do agree with both of trask's rewording suggestions, but otherwise this looks good as is.
chalin
reviewed
Feb 4, 2025
| - A Redis cache of auth tokens as `peer.service="AuthTokenCache"`. | ||
| - A gRPC service `rpc.service="io.opentelemetry.AuthService"` may be hosted in both a gateway, `peer.service="ExternalApiService"` and a backend, `peer.service="AuthService"`. | ||
|
|
||
| ## General identity attributes |
Contributor
There was a problem hiding this comment.
With this link-target gone, what should be used instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1104