Moved general semantic conventions markdown to a topic folder.#143
Merged
reyang merged 5 commits intoopen-telemetry:mainfrom Jun 30, 2023
Merged
Moved general semantic conventions markdown to a topic folder.#143reyang merged 5 commits intoopen-telemetry:mainfrom
reyang merged 5 commits intoopen-telemetry:mainfrom
Conversation
8f6ee08 to
624136b
Compare
joaopgrassi
approved these changes
Jun 28, 2023
Member
joaopgrassi
left a comment
There was a problem hiding this comment.
Looks all good to me. Will do another pass once #141 is merged since it will be easier/less changed files then 👍
This was referenced Jun 28, 2023
624136b to
aa02ca0
Compare
jsuereth
reviewed
Jun 28, 2023
Contributor
jsuereth
left a comment
There was a problem hiding this comment.
Overall Looks good.
One change needed though - Can you update "Logging" codeowners (tigran) so that the new "general" event/log semantic conventions will ping him for review?
Member
Author
Done. |
joaopgrassi
approved these changes
Jun 29, 2023
2aa586f to
1abfedc
Compare
jsuereth
approved these changes
Jun 29, 2023
291361e to
10a8b95
Compare
Merged
reyang
reviewed
Jun 30, 2023
reyang
approved these changes
Jun 30, 2023
430616e to
7c0d58f
Compare
This was referenced Jun 30, 2023
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
7c0d58f to
36c4093
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #137
Depends on #141