Skip to content

[k8s] Define missing roles for entity attributes#3135

Merged
lmolkova merged 2 commits intoopen-telemetry:mainfrom
ChrsMark:complete_k8s_entities
Dec 16, 2025
Merged

[k8s] Define missing roles for entity attributes#3135
lmolkova merged 2 commits intoopen-telemetry:mainfrom
ChrsMark:complete_k8s_entities

Conversation

@ChrsMark
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark commented Nov 26, 2025

Related to #3120

Changes

This PR adds roles for entity attributes that were missing this.

⚠️ Note that for k8s.namespace.name can be an identifying attribute within the scope of a K8s a cluster, hence k8s.namespace.uid is not defined at all nor used in k8sattributes processor of the Collector. I'd love to hear what people think about this and if we should consider introducing the k8s.namespace.uid as an identifying attribute for consistency across k8s resources/entities.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@ChrsMark ChrsMark requested review from a team as code owners November 26, 2025 10:30
@github-actions github-actions Bot added enhancement New feature or request area:k8s labels Nov 26, 2025
@ChrsMark ChrsMark self-assigned this Nov 26, 2025
@ChrsMark ChrsMark force-pushed the complete_k8s_entities branch from c88d0d0 to 26fcdd3 Compare November 26, 2025 10:36
@lmolkova lmolkova moved this from Untriaged to Awaiting codeowners approval in Semantic Conventions Triage Nov 28, 2025
@ChrsMark ChrsMark force-pushed the complete_k8s_entities branch from 26fcdd3 to e40da0f Compare December 2, 2025 10:40
@ChrsMark
Copy link
Copy Markdown
Member Author

ChrsMark commented Dec 2, 2025

/cc @open-telemetry/semconv-k8s-approvers

Comment thread model/k8s/entities.yaml Outdated
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark force-pushed the complete_k8s_entities branch from e40da0f to 3f6451e Compare December 8, 2025 08:35
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
Copy link
Copy Markdown
Member Author

@open-telemetry/semconv-k8s-approvers please take a look

@ChrsMark ChrsMark moved this to In Review in K8s SemConv SIG Dec 13, 2025
@lmolkova lmolkova moved this from Awaiting codeowners approval to Ready to be Merged in Semantic Conventions Triage Dec 15, 2025
@lmolkova lmolkova enabled auto-merge December 15, 2025 21:16
@lmolkova lmolkova added this pull request to the merge queue Dec 16, 2025
Merged via the queue into open-telemetry:main with commit 26d6155 Dec 16, 2025
18 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in K8s SemConv SIG Dec 16, 2025
Cirilla-zmh pushed a commit to Cirilla-zmh/semantic-conventions that referenced this pull request Feb 3, 2026
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:k8s enhancement New feature or request

Projects

Status: Done
Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants