-
Notifications
You must be signed in to change notification settings - Fork 985
Sampling: Introduce decision/flag to not propagate a span. #1663
Copy link
Copy link
Open
Labels
area:samplingRelated to trace samplingRelated to trace samplingarea:sdkRelated to the SDKRelated to the SDKrelease:allowed-for-gaEditorial changes that can still be added before GA since they don't require action by SIGsEditorial changes that can still be added before GA since they don't require action by SIGsspec:traceRelated to the specification/trace directoryRelated to the specification/trace directory
Metadata
Metadata
Assignees
Labels
area:samplingRelated to trace samplingRelated to trace samplingarea:sdkRelated to the SDKRelated to the SDKrelease:allowed-for-gaEditorial changes that can still be added before GA since they don't require action by SIGsEditorial changes that can still be added before GA since they don't require action by SIGsspec:traceRelated to the specification/trace directoryRelated to the specification/trace directory
Type
Fields
Give feedbackNo fields configured for issues without a type.
An idea that I had for #1653 (comment): With the current sampling decisions, you cannot suppress propagation of a Span. You can only influence the sampled flag on the traceflags. In some situations it might be desired to not propagate the span at all cross-process, i.e. cause inject(context) to be a no-op (for the Span part of the context).
This could be added as a new sampling decision that is otherwise equivalent to DROP, or it could be added as an additional boolean flag orthogonal to the current sampling decisions to also allow e.g. RECORDING spans that are only propagated in-process (could be used in combination with the URL which might be available to samplers to not propagate span contexts to external services).