Don't set STATUS on SpanKind SERVER for 4XX status#776
Don't set STATUS on SpanKind SERVER for 4XX status#776lzchen merged 6 commits intoopen-telemetry:mainfrom
Conversation
| Status(http_status_to_status_code(int(params.response.status))) | ||
| Status( | ||
| http_status_to_status_code( | ||
| int(params.response.status), server_span=True |
There was a problem hiding this comment.
This should be excluded since this is HTTP Client?
|
@lzchen @lonewolf3739 @owais
any chance you guys have some idea? not sure what further details to provide |
|
@talboren could you please create an issue for this and share the output of |
That was exactly it. |
@owais so seems like it wasn't that, I'm opening an issue and will post pip freeze results in there. |
From spec
For HTTP status codes in the 4xx range span status MUST be left unset in case of SpanKind.SERVER