Fix build script to not release stable pkgs#743
Merged
ocelotl merged 1 commit intoopen-telemetry:mainfrom Oct 15, 2021
Merged
Conversation
8d9538d to
3f7e026
Compare
3f7e026 to
e689ef1
Compare
ocelotl
approved these changes
Oct 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #598 we modified the release skip to not release packages that have hit
1.0.0because they should be released using a pushedtag.After the latest release however,
1.0.0+ packages were released together with the beta packages when using this script. They should not have been. The problem was that we were using Double Square brackets[[to do a "bash" test but this is not available on GitHub's shell environment and so the check was being ignoredThis PR fixes this by using a test method for the regex match that should work for any POSIX compliant shell.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
./scripts/build.shbecause I don't see the1.0.0+ components.1.0.0packages.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
- [ ] Changelogs have been updated- [ ] Unit tests have been added- [ ] Documentation has been updated