Skip to content

Fix build script to not release stable pkgs#743

Merged
ocelotl merged 1 commit intoopen-telemetry:mainfrom
NathanielRN:fix-build-script-to-not-release-stable-pkgs
Oct 15, 2021
Merged

Fix build script to not release stable pkgs#743
ocelotl merged 1 commit intoopen-telemetry:mainfrom
NathanielRN:fix-build-script-to-not-release-stable-pkgs

Conversation

@NathanielRN
Copy link
Copy Markdown
Contributor

Description

In #598 we modified the release skip to not release packages that have hit 1.0.0 because they should be released using a pushed tag.

After the latest release however, 1.0.0+ packages were released together with the beta packages when using this script. They should not have been. The problem was that we were using Double Square brackets [[ to do a "bash" test but this is not available on GitHub's shell environment and so the check was being ignored

This PR fixes this by using a test method for the regex match that should work for any POSIX compliant shell.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • It works locally when I run ./scripts/build.sh because I don't see the 1.0.0+ components.
  • It also works on GitHub runners because I pushed the change to my fork and I can confirm that the 1.0.0 packages get skipped
  • In that same workflow, you can see that no wheel is generated for the 1.0.0 packages.

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
    - [ ] Changelogs have been updated
    - [ ] Unit tests have been added
    - [ ] Documentation has been updated

@NathanielRN NathanielRN requested a review from a team October 14, 2021 22:48
@NathanielRN NathanielRN added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 14, 2021
@NathanielRN NathanielRN force-pushed the fix-build-script-to-not-release-stable-pkgs branch from 8d9538d to 3f7e026 Compare October 14, 2021 22:49
@NathanielRN NathanielRN force-pushed the fix-build-script-to-not-release-stable-pkgs branch from 3f7e026 to e689ef1 Compare October 15, 2021 04:00
@ocelotl ocelotl merged commit f7256f5 into open-telemetry:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants