Fix mssql docker tests v4#727
Merged
ocelotl merged 2 commits intoopen-telemetry:mainfrom Oct 12, 2021
Merged
Conversation
These were not really needed and got in by mistake.
e5d242e to
dfcbf65
Compare
f6fcaea to
aa38343
Compare
We were giving mssql server 10 seconds to start before creating the test database. It now takes Github CI more than 10 seconds to start the mssql server. Instead of increasing the leeway with guesses, this commit moves the creation of test database from docker compose to the python test suite. This allows the docker image to come up first and then create the DB inside the test suite with proper retry mechanism that is already in place.
aa38343 to
b4a11ca
Compare
owais
commented
Oct 12, 2021
| curl https://packages.microsoft.com/keys/microsoft.asc | sudo apt-key add - | ||
| sudo sh -c "echo 'deb [arch=amd64,armhf,arm64] https://packages.microsoft.com/ubuntu/20.04/prod focal main' > /etc/apt/sources.list.d/mssql-release.list" | ||
| sudo apt-get update | ||
| sudo ACCEPT_EULA=Y apt-get install -y msodbcsql17 |
Contributor
Author
There was a problem hiding this comment.
These changes are not really required. These were needed to fix related issues on an Ubuntu VM but the image we are using in CI doesn't need this.
Changes from #726
ocelotl
approved these changes
Oct 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We were giving mssql server 10 seconds to start before creating the test
database. It now takes Github CI more than 10 seconds to start the mssql
server. Instead of increasing the leeway with guesses, this commit moves
the creation of test database from docker compose to the python test suite.
This allows the docker image to come up first and then create the DB
inside the test suite with proper retry mechanism that is already in
place.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.