Skip to content

add a test for urllib using NoOpTracerProvider#1560

Merged
srikanthccv merged 6 commits intoopen-telemetry:mainfrom
avzis:urllib_no_op_tracer
Jan 10, 2023
Merged

add a test for urllib using NoOpTracerProvider#1560
srikanthccv merged 6 commits intoopen-telemetry:mainfrom
avzis:urllib_no_op_tracer

Conversation

@avzis
Copy link
Contributor

@avzis avzis commented Jan 3, 2023

Description

Add a test for urllib instrumentation to ensure that NoOpTracerProvider works

Fixes #961

How Has This Been Tested?

  • Instrument the library using a NoOpTracerProvider. the test validates that no spans are being produced.

Does This PR Require a Core Repo Change?

  • No.

@avzis avzis marked this pull request as ready for review January 4, 2023 08:26
@avzis avzis requested a review from a team January 4, 2023 08:26
@srikanthccv srikanthccv added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 6, 2023
@srikanthccv srikanthccv enabled auto-merge (squash) January 6, 2023 17:07
@srikanthccv srikanthccv merged commit d1dec92 into open-telemetry:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit and test opentelemetry-instrumentation-urllib

3 participants