add elasticsearch to docs#1542
Merged
srikanthccv merged 10 commits intoopen-telemetry:mainfrom Jan 6, 2023
Merged
Conversation
srikanthccv
reviewed
Jan 1, 2023
docs-requirements.txt
Outdated
| boto~=2.0 | ||
| botocore~=1.0 | ||
| celery>=4.0 | ||
| elasticsearch>=2.0 |
Member
There was a problem hiding this comment.
Isn't there a max version for this? This kind of pinning led us to build quite sometimes when a new major version is release with breaking changes.
Member
Author
There was a problem hiding this comment.
I agree but wanted this to match pyproject.toml. This might be out-of-scope for this PR but I suggest limiting elasticsearch v for both places WDYT?
srikanthccv
approved these changes
Jan 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable readthedocs auto-generated documentation to parse init.py doc
Fixes #1497
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?