Skip to content

gRPC Instrumentation - Support of metrics, messages as span events, conformity to official grpc.ClientInterceptor and bug fixes#1226

Closed
CoLa5 wants to merge 41 commits intoopen-telemetry:mainfrom
CoLa5:grpc_dev
Closed

gRPC Instrumentation - Support of metrics, messages as span events, conformity to official grpc.ClientInterceptor and bug fixes#1226
CoLa5 wants to merge 41 commits intoopen-telemetry:mainfrom
CoLa5:grpc_dev

Conversation

@CoLa5
Copy link
Contributor

@CoLa5 CoLa5 commented Aug 14, 2022

Description

Major Redesign of gRPC Instrumentation, including:

New Feature

Bug Fixes

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e test-instrumentation-grpc runs adapted instrumentation/opentelemetry-instrumentation-grpc/tests/test_client_interceptor.py and instrumentation/opentelemetry-instrumentation-grpc/tests/test_server_interceptor.py which test metrics, creation of span events and conformity of interfaces on client-side

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@CoLa5 CoLa5 requested a review from a team August 14, 2022 11:24
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 14, 2022

CLA Missing ID CLA Not Signed

@CoLa5 CoLa5 marked this pull request as draft August 14, 2022 12:33
@CoLa5 CoLa5 closed this Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant