-
Notifications
You must be signed in to change notification settings - Fork 906
Closed
Labels
Description
Before opening a feature request against this repo, consider whether the feature should/could be implemented in the other OpenTelemetry client libraries. If so, please open an issue on opentelemetry-specification first.
Is your feature request related to a problem?
If so, provide a concise description of the problem.
- instrumentation has it's own version requirement for dependencies, for example: opentelemetry-instrumentation-httpx requires
httpx >= 0.18.0, < 0.19.0. Instrumentation won't function if dependencies requirements not meet.
Line 16 in 4e3aaa5
_instruments = ("httpx >= 0.18.0, < 0.19.0",) - But the version requirement is not add in setup.py, therefore, dependency the requirements cannot be solved automatically by tools like pip-tools. to make instrumentation works, user needs to fix the dependencies manually.
Describe the solution you'd like
What do you want to happen instead? What is the expected behavior?
Add version requirement info in setup.py, so the dependency requirements/conflicts can be solved automatically.
setup(
...
install_requires=[
"httpx>=0.18.0,<0.19.0",
...
Describe alternatives you've considered
Which alternative solutions or features have you considered?
Additional context
Add any other context about the feature request here.
Reactions are currently unavailable