fix: log and trace processor memory leak#4449
Merged
lzchen merged 9 commits intoopen-telemetry:mainfrom Apr 9, 2025
Merged
Conversation
95a4774 to
da51419
Compare
Update register_at_fork calls in processors to use weak references Add tests for all processors that us register_at_fork Strong references in register_at_fork persist after the processor objects are deleted. This prevents garbage collection as the reference count for the processor object never drops to 0.
da51419 to
8f0efad
Compare
aabmass
approved these changes
Apr 4, 2025
Member
aabmass
left a comment
There was a problem hiding this comment.
Thanks LGTM! Since there is no way to unregister the actual at fork hook, this still leaks those lambdas but I imagine it's negligible.
emdneto
approved these changes
Apr 9, 2025
3 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Strong references in
register_at_forkpersist after the processor objects are deleted.This prevents garbage collection as the reference count for the processor object never drops to 0.
Update
register_at_forkcalls in processors to use weak referencesAdd tests for all processors that us
register_at_forkFixes #4422
Type of change
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: