opentelemetry-sdk: clarify Resource.create usage#4372
Merged
aabmass merged 4 commits intoopen-telemetry:mainfrom Dec 23, 2024
Merged
opentelemetry-sdk: clarify Resource.create usage#4372aabmass merged 4 commits intoopen-telemetry:mainfrom
aabmass merged 4 commits intoopen-telemetry:mainfrom
Conversation
After open-telemetry#3181 ResourceDetector instances cannot call Resource.create otherwise when using auto-instrumentation you'll go into an infinite loop trying to load resource detectors.
aabmass
approved these changes
Dec 23, 2024
Member
aabmass
left a comment
There was a problem hiding this comment.
Also consider maybe mentioning it ResourceDetector's docstring for implementors
Co-authored-by: Aaron Abbott <aaronabbott@google.com>
Co-authored-by: Aaron Abbott <aaronabbott@google.com>
tammy-baylis-swi
approved these changes
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #3181 ResourceDetector instances cannot call Resource.create otherwise when using auto-instrumentation you'll go into an infinite loop trying to load resource detectors.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: