Conversation
xrmx
left a comment
There was a problem hiding this comment.
Maybe we can just skip the A instead?
docs/conf.py
Outdated
|
|
||
| project = "OpenTelemetry Python" | ||
| copyright = "OpenTelemetry Authors" # pylint: disable=redefined-builtin | ||
| docs_copyright = "OpenTelemetry Authors" # pylint: disable=redefined-builtin |
There was a problem hiding this comment.
I am pretty sure we cannot change sphinx configuration for pleasing some lint rules 😅 see
https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-copyright
| if len(parts) > 1: # one or more properties metadata | ||
| for property in parts[1:]: | ||
| if _PROPERT_PATTERN.fullmatch(property) is None: | ||
| for properties in parts[1:]: |
There was a problem hiding this comment.
Maybe prop instead since this looks like is one property?
There was a problem hiding this comment.
prop, properties or no change?
| return SpanShim(self, context, span) | ||
|
|
||
| def inject(self, span_context, format: object, carrier: object): | ||
| def inject(self, span_context, formats: object, carrier: object): |
There was a problem hiding this comment.
Not sure we can rename function parameters because a linter rule does not like it :)
There was a problem hiding this comment.
Yes, in this case, I think we can just ignore it.
|
Maybe I'll just revert back all changes and just stick to adding rules. :) |
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
|
This PR has been closed due to inactivity. Please reopen if you would like to continue working on it. |
Description
Address part of #4227
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Aaffects variable, argument, import, module names.)Does This PR Require a Contrib Repo Change?
Checklist: