Handle TypeError from opentelemetry.context.contextvars_context in detach#4164
Closed
hyoinandout wants to merge 2 commits intoopen-telemetry:mainfrom
Closed
Handle TypeError from opentelemetry.context.contextvars_context in detach#4164hyoinandout wants to merge 2 commits intoopen-telemetry:mainfrom
hyoinandout wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
xrmx
reviewed
Sep 4, 2024
opentelemetry-api/src/opentelemetry/context/contextvars_context.py
Outdated
Show resolved
Hide resolved
a0b5f23 to
8c6b4c6
Compare
Contributor
|
Also please convert to a PR when ready for review. |
Contributor
Author
|
Hi @lzchen, sure, I would like to, just wondering why the checks for instrumentation failed... May I have to implement Context to be subscriptable in this PR? |
1 task
10 tasks
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
|
This PR has been closed due to inactivity. Please reopen if you would like to continue working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4163 (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: