Fix CI: Bump mypy to 0.982#3776
Merged
lzchen merged 1 commit intoopen-telemetry:mainfrom Mar 14, 2024
Merged
Conversation
Fixes broken mypy runs: .tox/mypy/lib/python3.10/site-packages/deprecated-stubs/classic.pyi:22: error: Positional-only parameters are only supported in Python 3.8 and greater
2 tasks
lzchen
approved these changes
Mar 14, 2024
aabmass
reviewed
Mar 14, 2024
Member
aabmass
left a comment
There was a problem hiding this comment.
Any idea how hard it would be to fix the new typing issues in this PR?
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes broken mypy runs:
Example of broken run:
https://github.com/open-telemetry/opentelemetry-python/actions/runs/8262935509/job/22603366489?pr=3773
We can bump mypy to newer versions but a lot more errors gets spotted so this is the newest release that works fine with just a couple of updates.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: