Skip to content

Use importlib-metadata regardless of Python version#3217

Merged
ocelotl merged 4 commits intoopen-telemetry:mainfrom
ocelotl:issue_3167_1
Mar 16, 2023
Merged

Use importlib-metadata regardless of Python version#3217
ocelotl merged 4 commits intoopen-telemetry:mainfrom
ocelotl:issue_3167_1

Conversation

@ocelotl
Copy link
Copy Markdown
Contributor

@ocelotl ocelotl commented Mar 14, 2023

Fixes #3167

@ocelotl ocelotl requested a review from a team March 14, 2023 20:38
@ocelotl ocelotl self-assigned this Mar 14, 2023
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 15, 2023
@lzchen
Copy link
Copy Markdown
Contributor

lzchen commented Mar 15, 2023

Does this replace this: #3168

@ocelotl
Copy link
Copy Markdown
Contributor Author

ocelotl commented Mar 15, 2023

@aabmass PTAL

Copy link
Copy Markdown
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@ocelotl ocelotl merged commit 6379c1c into open-telemetry:main Mar 16, 2023
@ocelotl ocelotl deleted the issue_3167_1 branch March 16, 2023 22:30
@whardier
Copy link
Copy Markdown

whardier commented May 4, 2023

It would be nice if we could still use a modern importlib-metadata vs ~=6.0.0

I would think ~=6.0 would work well for this eh? Any chance OP can resolve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make entry_points behave the same across Python versions

4 participants