Adding Codespell to the CI#2878
Conversation
|
When this is approved, we may want to do the same for the python-contrib. I'll open an issue and submit a fix once I gets approval for this one making sure that it is the right way to do it. |
|
I've broken this down to two commits so it's easier to review: the first adds codespell to the CI, and the second is just all the typo fixes |
|
Also, I have added spellcheck as another workflow, let me know if you think it makes more sense to place it under the lint testenv. I felt like it was a bit outside of lint scope, but both sounds totally reasonable to me so up to approvers :) |
|
There was another PR which fixed the typos. It got merged. Please rebase your branch. I think we should also add this in actions workflow. |
|
@srikanthccv branch updated (via a merge but if we are squashing I think it doesn't matter, since it now detects 4 changed files, let me know if I am wrong). Regarding the actions workflow, I think it will be automatically added since the |
|
It runs the tox but as you added a new environment for spellcheck it's not run automatically. You should update this line https://github.com/open-telemetry/opentelemetry-python/blob/main/.github/workflows/test.yml#L95 |
|
Done. Two final questions to make sure this is the thing we want:
|
|
looks like |
Description
Fixes #2871. Adding spellcheck on all files as part of the tox phase in the build. Additionally, fixed all discovered typos so the CI will pass.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This PR essentially adds a test. To run spellcheck run
tox -e spellcheckDoes This PR Require a Contrib Repo Change?
Checklist:
CONTRIBUTING.md