Add timeouts to metric SDK #2653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11c51db to
c66b40b
Compare
This was referenced May 2, 2022
ocelotl
reviewed
May 4, 2022
Contributor
ocelotl
left a comment
There was a problem hiding this comment.
Just to be sure, the idea for this PR is just to add a timeout parameter that is to be implemented by underlying components, right?
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/export/__init__.py
Outdated
Show resolved
Hide resolved
srikanthccv
reviewed
May 5, 2022
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
...pentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/__init__.py
Outdated
Show resolved
Hide resolved
srikanthccv
approved these changes
May 6, 2022
ocelotl
approved these changes
May 6, 2022
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
lzchen
reviewed
May 6, 2022
lzchen
reviewed
May 6, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/export/__init__.py
Show resolved
Hide resolved
lzchen
reviewed
May 6, 2022
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Show resolved
Hide resolved
lzchen
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #2402
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tests pass
Does This PR Require a Contrib Repo Change?
Checklist: