Skip to content

Add AlwaysRecordSampler#1836

Merged
brettmc merged 7 commits intoopen-telemetry:mainfrom
vitorvasc:alwaysrecord-sampler
Jan 20, 2026
Merged

Add AlwaysRecordSampler#1836
brettmc merged 7 commits intoopen-telemetry:mainfrom
vitorvasc:alwaysrecord-sampler

Conversation

@vitorvasc
Copy link
Copy Markdown
Member

@vitorvasc vitorvasc commented Dec 17, 2025

Description

  • Add AlwaysRecordSampler to OpenTelemetry\SDK\Trace\Sampler.

Related issue

Closes #1834.

@vitorvasc
feat(trace): add AlwaysRecordSampler
c1c6222 
Signed-off-by: Vitor Vasconcellos <vitor.vasconcellos@mercadolivre.com>
@vitorvasc
docs: improve phpDoc for AlwaysRecordSampler
8d313b8 
Signed-off-by: Vitor Vasconcellos <vitor.vasconcellos@mercadolivre.com>
@vitorvasc
test: add tests for AlwaysRecordSampler
1543588 
Signed-off-by: Vitor Vasconcellos <vitor.vasconcellos@mercadolivre.com>
@vitorvasc vitorvasc requested a review from a team as a code owner December 17, 2025 12:10
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.34%. Comparing base (13636b3) to head (7fa8e07).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1836      +/-   ##
============================================
- Coverage     68.38%   68.34%   -0.05%     
- Complexity     2978     2982       +4     
============================================
  Files           450      451       +1     
  Lines          8731     8748      +17     
============================================
+ Hits           5971     5979       +8     
- Misses         2760     2769       +9
Flag Coverage Δ
8.2 68.32% <100.00%> (+0.08%) ⬆️
8.3 68.28% <100.00%> (+0.02%) ⬆️
8.4 68.32% <100.00%> (+0.03%) ⬆️
8.5 67.47% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SDK/Trace/Sampler/AlwaysRecordSampler.php 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13636b3...7fa8e07. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vitorvasc vitorvasc marked this pull request as draft December 17, 2025 12:16
@vitorvasc
chore: fix linter warnings
a5c2d70 
Signed-off-by: Vitor Vasconcellos <vitor.vasconcellos@mercadolivre.com>
@vitorvasc
Copy link
Copy Markdown
Member Author

vitorvasc commented Dec 17, 2025

I'm not sure whether these errors on PHP QA are related to this PR 😬. Apparently, the same checks also failed for the last commit on the main branch.

image

@vitorvasc vitorvasc marked this pull request as ready for review December 17, 2025 21:50
@brettmc
Copy link
Copy Markdown
Contributor

brettmc commented Dec 19, 2025

the same checks also failed for the last commit on the main branch

Agreed, those failures look unrelated.

brettmc
brettmc reviewed Dec 19, 2025
View reviewed changes
@vitorvasc
docs: update phpDoc for AlwaysRecordSampler, add @experimental tag
8606310 
Signed-off-by: Vitor Vasconcellos <vitor.vasconcellos@mercadolivre.com>
@brettmc
Copy link
Copy Markdown
Contributor

brettmc commented Jan 17, 2026

Hi @vitorvasc sorry for the delay. Can you look at failing static analysis checks? Currently, it's a minor php-cs-fixer complaint, but there could be others that haven't run yet.

@vitorvasc
Copy link
Copy Markdown
Member Author

vitorvasc commented Jan 19, 2026

Hi @brettmc, thanks for the heads-up. I've just pushed the fixes for the static analysis, but the check for PHP 8.1 is still broken - and I can't quite figure out where the error is coming from.

image

I also noticed that codecov is failing, even though the coverage for the new files is still at 100%. Could this be related to this PR?

image

@brettmc brettmc merged commit 097859b into open-telemetry:main Jan 20, 2026
7 of 9 checks passed
@vitorvasc vitorvasc deleted the alwaysrecord-sampler branch January 26, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettmc brettmc brettmc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for AlwaysRecord sampler

2 participants

@vitorvasc @brettmc