This repository was archived by the owner on Nov 17, 2025. It is now read-only.
chore: move baggage methods in propagation namespace#55
Merged
obecny merged 2 commits intoopen-telemetry:mainfrom May 14, 2021
Merged
chore: move baggage methods in propagation namespace#55obecny merged 2 commits intoopen-telemetry:mainfrom
obecny merged 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 94.62% 94.66% +0.04%
==========================================
Files 40 40
Lines 502 506 +4
Branches 80 80
==========================================
+ Hits 475 479 +4
Misses 27 27
Continue to review full report at Codecov.
|
obecny
reviewed
May 13, 2021
Member
obecny
left a comment
There was a problem hiding this comment.
Because the methods will be available under propagation namespace instead of global, i think you should add info to Upgrade Guidelines, other than that lgtm
dyladan
approved these changes
May 13, 2021
Member
dyladan
left a comment
There was a problem hiding this comment.
I agree with bart you should update the upgrade guidelines. Other than that LGTM so I will approve
0d5668d to
9268926
Compare
Member
Author
|
@obecny I rebased + added the upgrade guideline, PTAL |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we moved the span context method into
tracenamespace, i'm also proposing to move[create/get/set]Baggageinto thepropagationnamespace.We still export
baggageEntryMetadataFromStringwhich feels kinda wrong to me since it doesn't do anything apart creating a unusued object, could we have a less strict type for the metadata so we don't need this function ?