This repository was archived by the owner on Nov 17, 2025. It is now read-only.
chore: rename span#context() to span#spanContext#45
Merged
dyladan merged 3 commits intoopen-telemetry:mainfrom Apr 26, 2021
Merged
chore: rename span#context() to span#spanContext#45dyladan merged 3 commits intoopen-telemetry:mainfrom
span#context() to span#spanContext#45dyladan merged 3 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 94.61% 94.61%
=======================================
Files 39 39
Lines 501 501
Branches 81 81
=======================================
Hits 474 474
Misses 27 27
Continue to review full report at Codecov.
|
vmarchaud
approved these changes
Apr 25, 2021
Flarna
approved these changes
Apr 26, 2021
Member
Flarna
left a comment
There was a problem hiding this comment.
Please add an entry in upgrade guideline
obecny
approved these changes
Apr 26, 2021
Member
obecny
left a comment
There was a problem hiding this comment.
lgtm, are there going to be a huge corresponding PR is core and contrib ?
Member
Author
yes |
9538416 to
f753b24
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35