Bytecode version upgrade for invokedynamic dispatch#9239
Merged
Conversation
…nstrumentation into indy-patch-old-bytecode
trask
reviewed
Aug 22, 2023
trask
approved these changes
Aug 23, 2023
mateuszrzeszutek
approved these changes
Aug 24, 2023
tylerbenson
approved these changes
Aug 24, 2023
tylerbenson
left a comment
Member
There was a problem hiding this comment.
I think it would help to indicate in the description how you intend to hook this in, otherwise seems ok to me.
Contributor
Author
@tylerbenson I've updated the PR description with an |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
invokedynamicdispatching strategy described in #8999, it requires the instrumented classes to at least have been compiled with Java 7 (51) in order to use theinvokedynamicinstruction.This transformer allows to upgrade the instrumented classes bytecode to Java 7 (51).
Implementation checklist
Usage
This PR only adds and tests one
AgentBuilder.Transformer, it is not yet applied on every instrumentation, that will be done in a later PR. Doing that will require to add this transformer in theio.opentelemetry.javaagent.tooling.instrumentation.InstrumentationModuleInstaller#installmethod.