Skip to content

Convert jetty-httpclient Groovy tests to Java#9072

Merged
mateuszrzeszutek merged 1 commit into
open-telemetry:mainfrom
pg-yang:jetty-client-test
Jul 31, 2023
Merged

Convert jetty-httpclient Groovy tests to Java#9072
mateuszrzeszutek merged 1 commit into
open-telemetry:mainfrom
pg-yang:jetty-client-test

Conversation

@pg-yang

@pg-yang pg-yang commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

related #7195

@pg-yang pg-yang requested a review from a team July 28, 2023 03:05
@pg-yang pg-yang force-pushed the jetty-client-test branch from c60c9cf to 071e323 Compare July 28, 2023 03:12
mateuszrzeszutek
mateuszrzeszutek reviewed Jul 28, 2023
View reviewed changes

@mateuszrzeszutek mateuszrzeszutek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pg-yang !
This is looking great, I left just a couple minor comments.

Comment thread ...java/io/opentelemetry/instrumentation/jetty/httpclient/v9_2/JettyHttpClient9LibraryTest.java Outdated
Comment thread ...opentelemetry/javaagent/instrumentation/jetty/httpclient/v9_2/JettyHttpClient9AgentTest.java Outdated
Comment thread ...in/java/io/opentelemetry/instrumentation/jetty/httpclient/v9_2/AbstractJettyClient9Test.java Outdated
Comment thread ...in/java/io/opentelemetry/instrumentation/jetty/httpclient/v9_2/AbstractJettyClient9Test.java Outdated
@pg-yang pg-yang force-pushed the jetty-client-test branch from f08281a to 525c1a6 Compare July 28, 2023 15:39
@pg-yang

pg-yang commented Jul 28, 2023

Copy link
Copy Markdown
Contributor Author

Hello, thanks for your suggestions. I think it's OK for now. And I have rebased the branch

mateuszrzeszutek
mateuszrzeszutek approved these changes Jul 31, 2023
View reviewed changes

@mateuszrzeszutek mateuszrzeszutek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pg-yang !

@mateuszrzeszutek mateuszrzeszutek merged commit 976dfb2 into open-telemetry:main Jul 31, 2023
@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Jul 31, 2023
Closed
@pg-yang pg-yang deleted the jetty-client-test branch July 31, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pg-yang @mateuszrzeszutek