Skip to content

Convert hibernate-3.3 tests from groovy to java#9025

Merged
trask merged 13 commits into
open-telemetry:mainfrom
jaydeluca:hibernate-3-3
Jul 26, 2023
Merged

Convert hibernate-3.3 tests from groovy to java#9025
trask merged 13 commits into
open-telemetry:mainfrom
jaydeluca:hibernate-3-3

Conversation

@jaydeluca

Copy link
Copy Markdown
Member

Related to #7195

@jaydeluca jaydeluca requested a review from a team July 23, 2023 13:46

@breedx-splk breedx-splk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not the easiest review. :) Looks to have the same coverage to me, and I appreciate eliminating some of the duplication that exists in the groovy implementation.

@trask trask merged commit 1c804ee into open-telemetry:main Jul 26, 2023
@trask

trask commented Jul 26, 2023

Copy link
Copy Markdown
Member

thx @jaydeluca!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants