converted couchbase-3.2 test from groovy to java#8837
Merged
Conversation
mateuszrzeszutek
approved these changes
Jun 30, 2023
Comment on lines
+7
to
+11
|
|
||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ |
Member
There was a problem hiding this comment.
There already is a copyright header on the top of the file
Suggested change
| /* | |
| * Copyright The OpenTelemetry Authors | |
| * SPDX-License-Identifier: Apache-2.0 | |
| */ |
Contributor
Author
There was a problem hiding this comment.
Thanks for the tip, slipped right by me
Member
|
Thanks @quinoant ! |
laurit
reviewed
Jun 30, 2023
| static Collection collection; | ||
|
|
||
| @BeforeAll | ||
| static void setupSpec() { |
Contributor
There was a problem hiding this comment.
setupSpec and cleanupSpec are spock conventions, for java tests we use setUp or setup and cleanUp, cleanup or tearDown
Contributor
Author
There was a problem hiding this comment.
Thanks for letting me know about the conventions, very helpful
mateuszrzeszutek
approved these changes
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #7195