Skip to content

Convert spring-core tests from groovy to java#8166

Merged
mateuszrzeszutek merged 8 commits into
open-telemetry:mainfrom
abhisesh:spring-core-test-java
Mar 31, 2023
Merged

Convert spring-core tests from groovy to java#8166
mateuszrzeszutek merged 8 commits into
open-telemetry:mainfrom
abhisesh:spring-core-test-java

Conversation

@abhisesh

Copy link
Copy Markdown
Contributor

Related to #7195.

Converts spring core instrumentation tests from groovy to java.

@abhisesh abhisesh requested a review from a team March 30, 2023 01:42
@mateuszrzeszutek

Copy link
Copy Markdown
Member

You'll need to add the following code snippet to build.gradle.kts to fix the failing checks:

// spring 6 requires java 17
if (findProperty("testLatestDeps") as Boolean) {
  otelJava {
    minJavaVersionSupported.set(JavaVersion.VERSION_17)
  }
}

Our latestDepTest jobs try to test the instrumentation against the most recent instrumented library version; for spring-core it's Spring 6.+, which requires Java 17 to compile and run.

abhisesh and others added 7 commits March 30, 2023 23:17
…/SimpleAsyncTaskExecutorInstrumentationTest.java

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
…/SimpleAsyncTaskExecutorInstrumentationTest.java

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

@mateuszrzeszutek mateuszrzeszutek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abhisesh !

@mateuszrzeszutek mateuszrzeszutek merged commit b23af1b into open-telemetry:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants