Skip to content

Convert Jetty 8.0 groovy to java#7975

Merged
laurit merged 23 commits into
open-telemetry:mainfrom
heyams:heya/convert-jedis-groovy-to-java
Mar 11, 2023
Merged

Convert Jetty 8.0 groovy to java#7975
laurit merged 23 commits into
open-telemetry:mainfrom
heyams:heya/convert-jedis-groovy-to-java

Conversation

@heyams

@heyams heyams commented Mar 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

related to #7195

@heyams heyams changed the title Convert jedis 8.0 groovy to java Convert Jetty 8.0 groovy to java Mar 4, 2023
@heyams

heyams commented Mar 7, 2023

Copy link
Copy Markdown
Contributor Author

does anyone know how to resolve 'Unable to load class 'Io_opentelemetry_instrumentation_muzzleGenerationPlugin'."?
i followed troubleshooting guide, same outcome though.

@mateuszrzeszutek

mateuszrzeszutek commented Mar 8, 2023

Copy link
Copy Markdown
Member

does anyone know how to resolve 'Unable to load class 'Io_opentelemetry_instrumentation_muzzleGenerationPlugin'."? i followed troubleshooting guide, same outcome though.

When does that happen?
Just to make sure -- in the last few days we've updated gradle version to 8.0, can you merge/rebase with main and try again?

@heyams

heyams commented Mar 8, 2023

Copy link
Copy Markdown
Contributor Author

does anyone know how to resolve 'Unable to load class 'Io_opentelemetry_instrumentation_muzzleGenerationPlugin'."? i followed troubleshooting guide, same outcome though.

When does that happen? Just to make sure -- in the last few days we've updated gradle version to 8.0, can you merge/rebase with main and try again?

It was auto resolved after I reboot my machine. Somehow my IntelliJ was in a weird state and messed up gradle. Thanks.

@heyams heyams marked this pull request as ready for review March 8, 2023 17:25
@heyams heyams requested a review from a team March 8, 2023 17:25
mateuszrzeszutek
mateuszrzeszutek reviewed Mar 9, 2023
View reviewed changes

@mateuszrzeszutek mateuszrzeszutek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help @heyams !

Comment thread ...nt/src/test/java/io/opentelemetry/javaagent/instrumentation/jetty/v8_0/JettyHandlerTest.java Outdated
Comment thread ...nt/src/test/java/io/opentelemetry/javaagent/instrumentation/jetty/v8_0/JettyHandlerTest.java Outdated
Comment thread ...nt/src/test/java/io/opentelemetry/javaagent/instrumentation/jetty/v8_0/JettyHandlerTest.java
@heyams heyams requested a review from mateuszrzeszutek March 9, 2023 19:45
@laurit laurit merged commit 468aa9e into open-telemetry:main Mar 11, 2023
@laurit laurit mentioned this pull request Mar 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurit laurit laurit approved these changes

+1 more reviewer

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heyams @mateuszrzeszutek @laurit