Skip to content

Migrate rxjava3 unit tests to Java#7924

Merged
mateuszrzeszutek merged 5 commits into
open-telemetry:mainfrom
kaibocai7:rxjava-unit-test
Apr 21, 2023
Merged

Migrate rxjava3 unit tests to Java#7924
mateuszrzeszutek merged 5 commits into
open-telemetry:mainfrom
kaibocai7:rxjava-unit-test

Conversation

@kaibocai7

@kaibocai7 kaibocai7 commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

Migrate rxjava3 unit tests from groovy to Java. #7195

@linux-foundation-easycla

linux-foundation-easycla Bot commented Feb 28, 2023

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: lonesomelilly / name: kc (d4ffdeb)

@kaibocai7 kaibocai7 marked this pull request as ready for review March 5, 2023 17:52
@kaibocai7 kaibocai7 requested a review from a team March 5, 2023 17:52
@kaibocai7

Copy link
Copy Markdown
Contributor Author

For the failed CI markdown-link-check seems due to the invalid links of Vert.x at supported-libraries.md

update testing logics for rxjava

update test instance level

migrate rxjava3 unit tests to java

sort traces for test - format code style

migrate rest of tests for rxjava3

format code style
@kaibocai7 kaibocai7 marked this pull request as draft April 4, 2023 12:11
fix more tests

fix comments - convert missed groovy tests
@kaibocai7 kaibocai7 marked this pull request as ready for review April 11, 2023 00:20

@mateuszrzeszutek mateuszrzeszutek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kaibocai7 !

@mateuszrzeszutek mateuszrzeszutek merged commit fd9ef74 into open-telemetry:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants