convert jboss-logmanager-mdc groovy test to java#7703
Merged
mateuszrzeszutek merged 6 commits intoFeb 3, 2023
Conversation
mateuszrzeszutek
left a comment
Member
There was a problem hiding this comment.
Thanks for help @cuichenli !
Member
Author
|
the test failed on another module, looks like i do not have the permission to re-run it. |
Contributor
|
@cuichenli you don't need to worry about test-latest-deps failure we'll fix it and let you know if this pr needs to be rebased. |
mateuszrzeszutek
approved these changes
Feb 3, 2023
Member
|
@opentelemetrybot update |
Member
|
(closing & reopening to trigger checks) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
getMdcCopytest is omitted as it is only available in jboss-logmanager 1.3+ and the test depends on jboss-logmanager 1.1