Skip to content

Convert vaadin tests to java#7444

Merged
trask merged 2 commits into
open-telemetry:mainfrom
laurit:vaadin-java
Jan 3, 2023
Merged

Convert vaadin tests to java#7444
trask merged 2 commits into
open-telemetry:mainfrom
laurit:vaadin-java

Conversation

@laurit

@laurit laurit commented Dec 18, 2022

Copy link
Copy Markdown
Contributor

Part of #7195
Resolves #7417
Vaadin tests often break with a new version of vaadin. To improve this tests were change to assert only the traces and spans that are common in all the versions.

@laurit laurit requested a review from a team December 18, 2022 20:13

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@trask trask merged commit d0bfc5b into open-telemetry:main Jan 3, 2023
@laurit laurit deleted the vaadin-java branch July 6, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vaadin test fails against 23.3.0

3 participants