Skip to content

Migrate some SQL sanitizer tests to java#7148

Merged
trask merged 4 commits into
open-telemetry:mainfrom
breedx-splk:sql_tests_to_java
Nov 15, 2022
Merged

Migrate some SQL sanitizer tests to java#7148
trask merged 4 commits into
open-telemetry:mainfrom
breedx-splk:sql_tests_to_java

Conversation

@breedx-splk

Copy link
Copy Markdown
Contributor

Is there a way to tell spotless to ignore a file? I feel like some manual formatting would be an improvement in these....

@breedx-splk breedx-splk requested a review from a team November 12, 2022 01:17
@mateuszrzeszutek

Copy link
Copy Markdown
Member

Is there a way to tell spotless to ignore a file? I feel like some manual formatting would be an improvement in these....

I think you can use

// @formatter:off
// @formatter:on

for that purpose

@breedx-splk

Copy link
Copy Markdown
Contributor Author
// @formatter:off

Hmph, I tried it around a block and around the class and couldn't get it to work either way. 🤷🏻 Not a big deal.

@breedx-splk

Copy link
Copy Markdown
Contributor Author

Build errors look maven related. I don't have perms to re-run the failed jobs.

@trask

trask commented Nov 15, 2022

Copy link
Copy Markdown
Member

@breedx-splk heads up I merged main into your branch to fix the CI failures

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@trask trask enabled auto-merge (squash) November 15, 2022 04:43
@trask trask merged commit d4b29cf into open-telemetry:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants