Don't set IP address for net.peer.name and set name for failed DNS lo…#584
Merged
Merged
Conversation
trask
reviewed
Jun 27, 2020
trask
left a comment
Member
There was a problem hiding this comment.
nice catch on the failed DNS lookup 👍
I sent suggestions as PR: anuraaga#1
* PR suggestion * Make test pass on Windows
anuraaga
commented
Jun 28, 2020
| if (remoteConnection != null) { | ||
| onPeerConnection(span, remoteConnection.getAddress()); | ||
|
|
||
| InetAddress remoteAddress = remoteConnection.getAddress(); |
Contributor
Author
There was a problem hiding this comment.
@trask Just confirming we should use final with local vars? I personally don't like it much but happy to follow the style
Member
There was a problem hiding this comment.
you are in good company 😄, we recently decided against it, just opened #592 to track updating existing style
trask
approved these changes
Jun 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…okup
When working on #562, I found
onPeerConnectionbehavior to not match my expectations. While the spec doesn't say truly explicitly, I interpret it as reverse lookup an IP address and fill in the name result if available, but otherwise don't fill an IP literal intonet.peer.namewhich currently happens.https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/span-general.md#netname-attributes
Also, losing
net.peer.nameon DNS failure seems like a very unfortunate loss of important data, I added so it's always set.The previous unit tests were missing cases of IP-address and really any coverage at all since they just called the code during expectations, hopefully as explicit expectations things are clearer now.