Writing InstrumentationModule line by line#2793
Merged
trask merged 3 commits intoApr 14, 2021
Merged
Conversation
This was referenced Apr 13, 2021
trask
approved these changes
Apr 13, 2021
trask
left a comment
Member
There was a problem hiding this comment.
😻
I felt like some sub-section headings would help, it was not always clear when jumping from one topic to another, so I suggested some heading, but not sure if it's too much, very happy with whatever you decide, this doc is 💯
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Member
Author
Those headings really make it look better, thanks! |
Member
|
🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2662
And resolves #536 -- after this is merged all questions/tasks will have been solved or have issues created for them.