Align 3.0 deprecation markers in javaagent-extension-api#18904
Merged
trask merged 1 commit intoJun 5, 2026
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes deprecation-removal markers within javaagent-extension-api to consistently use the repository’s common “3.0” wording, and adds the missing removal note for the deprecated IgnoredTypesConfigurer#configure(IgnoredTypesBuilder, ConfigProperties) overload.
Changes:
- Added an explicit “Will be removed in 3.0.” note to the deprecated
IgnoredTypesConfigureroverload Javadoc. - Normalized
@Deprecatedremoval comments from “will be removed in 3.0.0” to “to be removed in 3.0” injavaagent-extension-api. - Updated the affected deprecation markers in the same module to align with the standardized wording.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/instrumentation/internal/V3PreviewFallbackEnabledInstrumentationModule.java | Normalizes the deprecation removal marker to “to be removed in 3.0”. |
| javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/instrumentation/InstrumentationModule.java | Updates the deprecated overload’s removal marker to the standardized “3.0” wording. |
| javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/ignore/IgnoredTypesConfigurer.java | Adds the missing 3.0 removal note in Javadoc and aligns the @Deprecated removal marker comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15806
What changed
IgnoredTypesConfigurer#configure(IgnoredTypesBuilder, ConfigProperties)javaagent-extension-apideprecation markers to the repo's more common3.0wording3.0.0markers in the same module to3.0Why
Issue #15806 called out that
IgnoredTypesConfigurershould have the same temporary removal marker comment used in other places.While fixing that, this also aligns the nearby
javaagent-extension-apicode with the more common repository pattern:@Deprecated // to be removed in 3.0Will be removed in 3.0.Impact
No functional behavior change. This is a comment / deprecation-marker consistency cleanup that also makes the future 3.0 removal audit easier.
Validation
./gradlew :javaagent-extension-api:compileJavaFollow-up