Convert Aws sdk 2.2 Client core tests from groovy to java#12949
Merged
Conversation
laurit
reviewed
Dec 23, 2024
laurit
reviewed
Dec 23, 2024
laurit
reviewed
Dec 23, 2024
laurit
reviewed
Dec 23, 2024
laurit
reviewed
Dec 23, 2024
laurit
reviewed
Dec 23, 2024
| equalTo(maybeStable(DB_OPERATION), operation)); | ||
| } | ||
|
|
||
| private static Stream<Arguments> provideArguments() { |
Contributor
There was a problem hiding this comment.
could use something like
@SuppressWarnings("unchecked")
private static DynamoDbClient wrapClient(DynamoDbAsyncClient asyncClient) {
return (DynamoDbClient)
Proxy.newProxyInstance(
DynamoDbClient.class.getClassLoader(),
new Class<?>[] {DynamoDbClient.class},
(proxy, method, args) -> {
Method asyncMethod =
DynamoDbAsyncClient.class.getMethod(method.getName(), method.getParameterTypes());
CompletableFuture<?> future =
(CompletableFuture<?>) asyncMethod.invoke(asyncClient, args);
return future.get();
});
}so that the parameters would not need to be duplicated between sync and async case. Async test could use Object response = call.apply(wrapClient(client)); Note that the response passed to validateOperationResponse won't be a Future any more with this.
Could generalize this to
@SuppressWarnings("unchecked")
protected static <T, U> T wrapClient(Class<T> syncClientClass, Class<U> asyncClientClass, U asyncClient) {
return (T)
Proxy.newProxyInstance(
AbstractAws2ClientCoreTest.class.getClassLoader(),
new Class<?>[] {syncClientClass},
(proxy, method, args) -> {
Method asyncMethod =
asyncClientClass.getMethod(method.getName(), method.getParameterTypes());
CompletableFuture<?> future =
(CompletableFuture<?>) asyncMethod.invoke(asyncClient, args);
return future.get();
});
}from what I noticed only s3 getObject has different parameters for sync and async.
Idk if the slightly reduced code size is worth it.
Member
Author
There was a problem hiding this comment.
you are a wizard. thank you for this suggestion
laurit
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #7195