convert redisscala tests from groovy to java#12553
Closed
shalk wants to merge 8 commits into
Closed
Conversation
laurit
reviewed
Nov 8, 2024
| static void setUp() throws Exception { | ||
| redisServer = new GenericContainer<>("redis:6.2.3-alpine").withExposedPorts(6379); | ||
| redisServer.start(); | ||
| // cleanup.deferCleanup(redisServer::stop); |
laurit
reviewed
Nov 8, 2024
Comment on lines
+56
to
+57
| host = redisServer.getHost(); | ||
| port = redisServer.getMappedPort(6379); |
laurit
reviewed
Nov 8, 2024
|
|
||
| @AfterAll | ||
| static void tearDown() throws Exception { | ||
| if (system != null) { |
Contributor
There was a problem hiding this comment.
groovy version also calls redisServer.stop()
laurit
reviewed
Nov 8, 2024
| import scala.Option; | ||
| import scala.concurrent.Future; | ||
|
|
||
| public class RediscalaClientTest { |
Contributor
There was a problem hiding this comment.
usually we make test classes package private
0084ca7 to
b9c424c
Compare
laurit
reviewed
Nov 11, 2024
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.RegisterExtension; | ||
| import org.testcontainers.containers.GenericContainer; | ||
| import org.testcontainers.shaded.org.apache.commons.lang3.tuple.Pair; |
Contributor
There was a problem hiding this comment.
we avoid using classes shaded into other libraries
laurit
reviewed
Nov 11, 2024
| .hasKind(CLIENT) | ||
| .hasParent(trace.getSpan(0)) | ||
| .hasAttributesSatisfyingExactly( | ||
| equalTo(DbIncubatingAttributes.DB_SYSTEM, "redis"), |
Contributor
There was a problem hiding this comment.
could you add a static import for DB_SYSTEM
Contributor
There was a problem hiding this comment.
also could use DbIncubatingAttributes .DbIncubatingAttributes.REDIS
laurit
reviewed
Nov 11, 2024
| return Pair.of(writeFuture, valueFuture); | ||
| }); | ||
|
|
||
| await().atMost(java.time.Duration.ofSeconds(3)).until(() -> result.getLeft().isCompleted()); |
Contributor
There was a problem hiding this comment.
could import java.time.Duration
laurit
reviewed
Nov 11, 2024
| false, | ||
| false, | ||
| serializer)); | ||
| await().atMost(java.time.Duration.ofSeconds(3)).until(value::isCompleted); |
Contributor
There was a problem hiding this comment.
just wondering whether it would be better to use scala await class like the groovy test does or maybe even consider converting the whole test to scala
Member
Author
There was a problem hiding this comment.
i think java class is enough to cover the instrument case
jaydeluca
reviewed
Nov 12, 2024
Comment on lines
+105
to
+106
| SettableFuture<Future<Object>> writeFutureRef = SettableFuture.create(); | ||
| ; |
Member
There was a problem hiding this comment.
Suggested change
| SettableFuture<Future<Object>> writeFutureRef = SettableFuture.create(); | |
| ; | |
| SettableFuture<Future<Object>> writeFutureRef = SettableFuture.create(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7195