Convert mongo-common tests from groovy to java#12382
Merged
Merged
Conversation
steverao
reviewed
Oct 3, 2024
steverao
reviewed
Oct 3, 2024
steverao
reviewed
Oct 3, 2024
… and "cleanup" 2. Collection tool class methods use static import Signed-off-by: xiepuhuan <puhuanxie@gmail.com>
jeanbisutti
reviewed
Oct 3, 2024
steverao
reviewed
Oct 3, 2024
Signed-off-by: xiepuhuan <puhuanxie@gmail.com>
Signed-off-by: xiepuhuan <puhuanxie@gmail.com>
steverao
reviewed
Oct 4, 2024
steverao
reviewed
Oct 4, 2024
2. Convert long to int using `Math.toIntExam`. Signed-off-by: xiepuhuan <puhuanxie@gmail.com>
steverao
reviewed
Oct 7, 2024
steverao
left a comment
Contributor
There was a problem hiding this comment.
BTW, don't forget to delete following unnecessary dependencies
Contributor
Author
Thanks. |
jaydeluca
reviewed
Oct 14, 2024
2. Close resources using AutoCleanupExtension 3. Reconstruct the mongoSpan method
laurit
reviewed
Oct 16, 2024
laurit
reviewed
Oct 16, 2024
laurit
reviewed
Oct 16, 2024
laurit
reviewed
Oct 16, 2024
laurit
reviewed
Oct 16, 2024
laurit
reviewed
Oct 16, 2024
laurit
reviewed
Oct 16, 2024
laurit
reviewed
Oct 16, 2024
laurit
reviewed
Oct 16, 2024
2. Change the return type of the involved method from int to long. 3. Using isIn instead of containsAnyOf for correct assertions. 4. Directly throw InterruptedException without capturing it. 5. Latch calls await method with timeout. 6. Merge comment lines. 7. Use the get method to wait for the future to complete, just like the original Groovy code. 8. In the mongoSpan method parameters, use SpanDataAsset instead of trace and index. 9. In the mongoSpan method, optimizing assertion error prompts. Signed-off-by: xiepuhuan <puhuanxie@gmail.com>
laurit
approved these changes
Oct 17, 2024
jaydeluca
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #7195