conver servlet 5 tests from groovy to java#12364
Merged
Merged
Conversation
Member
Author
|
@laurit do I need to create a jetty11 testing project to get rid of this? |
Contributor
|
We have two kinds of modules that are named |
laurit
reviewed
Oct 1, 2024
Member
Author
|
@laurit can you check again? |
2 similar comments
Member
Author
|
@laurit can you check again? |
Member
Author
|
@laurit can you check again? |
laurit
reviewed
Oct 17, 2024
laurit
reviewed
Oct 17, 2024
laurit
reviewed
Oct 17, 2024
laurit
reviewed
Oct 17, 2024
8af9827 to
2f52981
Compare
laurit
approved these changes
Oct 18, 2024
jaydeluca
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by copying the servlet 3 tests and then applying the diffs from between the groovy servlet 3 and groovy servlet 5 tests