Skip to content

Convert play-mvc-2.6 groovy to java#12340

Merged
trask merged 11 commits into
open-telemetry:mainfrom
heyams:heya/convert-play-mvc-2.6-groovy-to-java
Oct 11, 2024
Merged

Convert play-mvc-2.6 groovy to java#12340
trask merged 11 commits into
open-telemetry:mainfrom
heyams:heya/convert-play-mvc-2.6-groovy-to-java

Conversation

@heyams

@heyams heyams commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@heyams heyams marked this pull request as ready for review September 30, 2024 18:46
@heyams heyams requested a review from a team as a code owner September 30, 2024 18:46
@heyams

heyams commented Oct 1, 2024

Copy link
Copy Markdown
Contributor Author

i expect this PR to be green after the CI build run :)
please review when you can.

Comment on lines +72 to +74
named("latestDepTest") {
enabled = testLatestDeps
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wasn't triggering latestDepTest module test when i have -PtestLatestDeps=true locally.

@laurit laurit Oct 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You sure about that? Seems to work fine for me. Perhaps nothing was run because you had already run the tests and got the results from build cache?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me 'invalidate cache' and try it without this.

@heyams

heyams commented Oct 9, 2024

Copy link
Copy Markdown
Contributor Author

will close and reopen to trigger CI builds rerun. errors are not related to my change.

@heyams heyams closed this Oct 9, 2024
@heyams heyams reopened this Oct 9, 2024
@jaydeluca

Copy link
Copy Markdown
Member

errors are not related to my change.

lauri's fix for those ktor failing tests was just merged in a few hours ago here, you might need to rebase/pull those into your branch to get this green

@trask trask merged commit a78ef27 into open-telemetry:main Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants