Skip to content

make internal-class-loader indy compatible#12195

Closed
SylvainJuge wants to merge 10 commits into
open-telemetry:mainfrom
SylvainJuge:indy-cl
Closed

make internal-class-loader indy compatible#12195
SylvainJuge wants to merge 10 commits into
open-telemetry:mainfrom
SylvainJuge:indy-cl

Conversation

@SylvainJuge

Copy link
Copy Markdown
Contributor

Part of #11457

Migrates the internal/classloader module to be indy-compatible.

Also removes leftover usages of readOnly = false for return values on a few other modules:

  • internal/osgi
  • internal-reflection (integration tests)
  • internal/internal-url-class-loader (integration tests)

@SylvainJuge

Copy link
Copy Markdown
Contributor Author

There are a few extra challenges discovered while implementing this:

  • the initial migration went well, but did not work for indy 192137a
  • I had to work-around a bug when skipOn is used and advices do not return an array d40c2b3
  • classloader instrumentation had to be migrated to ASM because it triggered stack overflow or nested invokedynamic invocations (instrument loading classes while loading advices/helper is probably not a very good mix).

@SylvainJuge SylvainJuge mentioned this pull request Sep 13, 2024
36 tasks
@SylvainJuge

Copy link
Copy Markdown
Contributor Author

Closing in favor of #12242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant