Skip to content

convert servlet tests to java#12013

Merged
laurit merged 43 commits into
open-telemetry:mainfrom
zeitlinger:convert-servlet-tests-to-java
Sep 24, 2024
Merged

convert servlet tests to java#12013
laurit merged 43 commits into
open-telemetry:mainfrom
zeitlinger:convert-servlet-tests-to-java

Conversation

@zeitlinger

@zeitlinger zeitlinger commented Aug 14, 2024 •
edited by jaydeluca
Loading

Copy link
Copy Markdown
Member

servlet 5 is very similar to 3 - will do that in a follow-up PR

related to #7195

@zeitlinger zeitlinger self-assigned this Aug 14, 2024
@zeitlinger zeitlinger requested a review from a team August 14, 2024 12:50
@zeitlinger zeitlinger mentioned this pull request Aug 14, 2024
Closed
steverao
steverao reviewed Aug 16, 2024
View reviewed changes
Comment thread ...src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v2_2/JettyServlet2Test.java Outdated
Comment thread ...src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v2_2/JettyServlet2Test.java Outdated
@zeitlinger zeitlinger force-pushed the convert-servlet-tests-to-java branch 3 times, most recently from 80e28a9 to 34035ee Compare August 23, 2024 12:52
@zeitlinger

zeitlinger commented Aug 26, 2024

Copy link
Copy Markdown
Member Author

@steverao can you take a look?

@zeitlinger zeitlinger force-pushed the convert-servlet-tests-to-java branch from ee06c0a to 6f5e60b Compare August 26, 2024 07:48
@zeitlinger

zeitlinger commented Aug 28, 2024

Copy link
Copy Markdown
Member Author

@laurit @steverao please check again

laurit
laurit reviewed Aug 29, 2024
View reviewed changes
Comment thread instrumentation/servlet/servlet-3.0/javaagent-tests/build.gradle.kts
@zeitlinger

zeitlinger commented Aug 30, 2024

Copy link
Copy Markdown
Member Author

@laurit please check again

@zeitlinger zeitlinger force-pushed the convert-servlet-tests-to-java branch from 4832af6 to 00d5b85 Compare August 30, 2024 16:48
@zeitlinger

zeitlinger commented Sep 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

@zeitlinger some of the review comments I left apply to multiple locations, could you apply the same changes everywhere where the same pattern is used

I hope I found them all now @laurit

@zeitlinger

zeitlinger commented Sep 9, 2024

Copy link
Copy Markdown
Member Author

@laurit please check again

@laurit laurit merged commit c55cbbe into open-telemetry:main Sep 24, 2024
@zeitlinger zeitlinger deleted the convert-servlet-tests-to-java branch September 26, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steverao steverao steverao left review comments

@laurit laurit laurit approved these changes

@jaydeluca jaydeluca jaydeluca approved these changes

Assignees

@zeitlinger zeitlinger

Labels

area:tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zeitlinger @laurit @jaydeluca @steverao