convert spring batch tests to java by zeitlinger · Pull Request #12004 · open-telemetry/opentelemetry-java-instrumentation

zeitlinger · 2024-08-13T09:12:50Z

Related to #7195

jaydeluca · 2024-08-18T20:00:25Z

would it be possible to break this into a couple smaller PRs for easier review?

zeitlinger · 2024-08-19T05:11:47Z

would it be possible to break this into a couple smaller PRs for easier review?

all tests use the JobRunner interface to work
I could put that in a separate PR, but I'm not sure it makes it easier to review

trask · 2024-08-19T22:32:03Z

would it be possible to break this into a couple smaller PRs for easier review?

all tests use the JobRunner interface to work I could put that in a separate PR, but I'm not sure it makes it easier to review

not sure I follow why you can't split this into smaller PRs? they can be stacked if needed

zeitlinger · 2024-08-21T16:01:35Z

not sure I follow why you can't split this into smaller PRs? they can be stacked if needed

ok I gave it a shot at #12076

zeitlinger · 2024-08-29T11:40:48Z

would it be possible to break this into a couple smaller PRs for easier review?

all tests use the JobRunner interface to work I could put that in a separate PR, but I'm not sure it makes it easier to review

not sure I follow why you can't split this into smaller PRs? they can be stacked if needed

with the first PR merged, this is the remaining changes - let me know if this is good as it is

zeitlinger · 2024-09-02T16:28:25Z

@laurit please check again

…a/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/event/JsrConfigCustomSpanEventTest.java Co-authored-by: Steve Rao <raozihao.rzh@alibaba-inc.com>

zeitlinger · 2024-09-10T11:49:57Z

@laurit please check again

zeitlinger added the area:tests label Aug 13, 2024

zeitlinger self-assigned this Aug 13, 2024

zeitlinger requested a review from a team August 13, 2024 09:12

steverao reviewed Aug 14, 2024

View reviewed changes

Comment thread ...java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/basic/SpringBatchTest.java Outdated

steverao reviewed Aug 14, 2024

View reviewed changes

Comment thread ...java/io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/basic/SpringBatchTest.java Outdated

steverao reviewed Aug 14, 2024

View reviewed changes

Comment thread .../io/opentelemetry/javaagent/instrumentation/spring/batch/v3_0/event/CustomSpanEventTest.java Outdated

steverao reviewed Aug 14, 2024

View reviewed changes

Comment thread ...elemetry/javaagent/instrumentation/spring/batch/v3_0/event/JsrConfigCustomSpanEventTest.java

zeitlinger mentioned this pull request Aug 14, 2024

Help wanted! Convert Groovy tests to Java #7195

Closed

zeitlinger force-pushed the spring-batch-tests-to-java branch from 7667682 to 51761cf Compare August 19, 2024 05:43

zeitlinger force-pushed the spring-batch-tests-to-java branch from 51761cf to 1ee063a Compare August 21, 2024 15:50

zeitlinger mentioned this pull request Aug 21, 2024

Spring batch tests to java - basic #12076

Merged

zeitlinger marked this pull request as draft August 22, 2024 07:07

zeitlinger force-pushed the spring-batch-tests-to-java branch from 2174b7e to 689b2e5 Compare August 29, 2024 11:18

zeitlinger marked this pull request as ready for review August 29, 2024 11:40