Skip to content

Muzzle should fail on unimplemented abstract methods#1193

Merged
iNikem merged 6 commits into
open-telemetry:masterfrom
mateuszrzeszutek:muzzle2
Sep 23, 2020
Merged

Muzzle should fail on unimplemented abstract methods#1193
iNikem merged 6 commits into
open-telemetry:masterfrom
mateuszrzeszutek:muzzle2

Conversation

@mateuszrzeszutek

@mateuszrzeszutek mateuszrzeszutek commented Sep 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Resolves #1123

@trask

trask commented Sep 12, 2020

Copy link
Copy Markdown
Member

Thank you for tackling this ❤️👍

@mateuszrzeszutek mateuszrzeszutek force-pushed the muzzle2 branch 17 times, most recently from 01e65e2 to 173db14 Compare September 18, 2020 14:58
@mateuszrzeszutek mateuszrzeszutek changed the title [WORK IN PROGRESS] Muzzle should fail on unimplemented abstract methods Muzzle should fail on unimplemented abstract methods Sep 18, 2020
@mateuszrzeszutek mateuszrzeszutek marked this pull request as ready for review September 18, 2020 16:10
@iNikem

iNikem commented Sep 18, 2020

Copy link
Copy Markdown
Contributor

Hei, @mateuszrzeszutek, maybe you can help @trask with #536 ;)

@trask

trask commented Sep 21, 2020

Copy link
Copy Markdown
Member

Hei, @mateuszrzeszutek, maybe you can help @trask with #536 ;)

💯

@mateuszrzeszutek I will review this PR tomorrow 👍

@mateuszrzeszutek

mateuszrzeszutek commented Sep 21, 2020

Copy link
Copy Markdown
Member Author

Hei, @mateuszrzeszutek, maybe you can help @trask with #536 ;)

Sure - after implementing this change I think I can answer at least half of these questions. I'll put it on my TODO list and push a PR soon.

iNikem
iNikem reviewed Sep 21, 2020
View reviewed changes
Comment thread ...-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/HelperReferenceWrapper.java Outdated
Comment thread javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/MuzzleVisitor.java
Comment thread javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/Reference.java
Comment thread javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/ReferenceMatcher.java
Comment thread javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/ReferenceMatcher.java Outdated
trask
trask reviewed Sep 22, 2020
View reviewed changes

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tried to see if this would have caught the ServletOutputStream issue? i gave it a try, but muzzle still didn't fail for me on unimplemented ServletOutputStream methods

Comment thread javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/Reference.java Outdated
Comment thread javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/Reference.java
Comment thread javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/ReferenceMatcher.java Outdated
Comment thread javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/ReferenceMatcher.java Outdated
Comment thread javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/ReferenceMatcher.java Outdated
Comment thread javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/ReferenceCreator.java
@trask
Update javaagent-tooling/src/main/java/io/opentelemetry/javaagent/too…
7df71f3 
…ling/muzzle/Reference.java

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@mateuszrzeszutek

mateuszrzeszutek commented Sep 22, 2020

Copy link
Copy Markdown
Member Author

have you tried to see if this would have caught the ServletOutputStream issue? i gave it a try, but muzzle still didn't fail for me on unimplemented ServletOutputStream methods

You're right, I unknowingly introduced a bug when I was refactoring the first working version. Thanks for noticing it! I'll add a unit test that covers this specific scenario.

trask
trask approved these changes Sep 22, 2020
View reviewed changes

@trask trask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉

@iNikem iNikem merged commit 3d03028 into open-telemetry:master Sep 23, 2020
@mateuszrzeszutek mateuszrzeszutek deleted the muzzle2 branch November 18, 2022 10:26
@trask trask mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@jkwatson jkwatson Awaiting requested review from jkwatson

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

+1 more reviewer

@iNikem iNikem iNikem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Muzzle should fail on unimplemented abstract methods

3 participants

@mateuszrzeszutek @trask @iNikem