Skip to content

Convert aws sdk 2.2 sqs tracing tests from groovy to java#11240

Merged
laurit merged 5 commits into
open-telemetry:mainfrom
jaydeluca:aws-2-2-sqs-tracing
Apr 30, 2024
Merged

Convert aws sdk 2.2 sqs tracing tests from groovy to java#11240
laurit merged 5 commits into
open-telemetry:mainfrom
jaydeluca:aws-2-2-sqs-tracing

Conversation

@jaydeluca

Copy link
Copy Markdown
Member

Related to #7195

@jaydeluca jaydeluca requested a review from a team April 26, 2024 21:51
return map;
}

ReceiveMessageRequest receiveMessageRequest =

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It had better to define the those fields in a class together.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you clarify what you mean for this one? I moved the queueUrl field closer to these methods that use it, but I'm not sure if that's what you are suggesting. Are you saying I should move these request fields into a new class?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you clarify what you mean for this one? I moved the queueUrl field closer to these methods that use it, but I'm not sure if that's what you are suggesting. Are you saying I should move these request fields into a new class?

What I actually mean is that all the fields in a class are defined in a piece of code, and then it is followed by some method definitions. I personally think this will make a class look clearer, for example, it will be easier to check whether some fields are used or whether the writing complies with the specification:)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense, thank you for the explanation

@laurit laurit merged commit 5737f1d into open-telemetry:main Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants